Telegram approval-aware task lane + promotion consistency#17
Draft
srxly888-creator wants to merge 18 commits intomainfrom
Draft
Telegram approval-aware task lane + promotion consistency#17srxly888-creator wants to merge 18 commits intomainfrom
srxly888-creator wants to merge 18 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR promotes the current Telegram task lane from patch-oriented execution to an approval-aware flow with consistent promotion state across Telegram, admin, and runtime artifacts.
It also closes a key control-plane gap after worker failures and adds step-level promotion observability for easier diagnosis of intermittent promotion failures.
Included changes
/taskapproval-awareKey behavior changes
/task <request>now defaults to an approval-aware path/task patch <request>explicitly stays patch-onlyready_for_promotiontransitions intoawaiting_approval/approve <approval_id> approvepromotes the task and can create a Draft PRReliability improvements
summary.jsonis forced even when post-processing fails afterdriver_result.jsonis writtencreate_branchapply_patchvalidatorcommitpushcreate_prValidation
Targeted regression suites
Live E2E
Validated end-to-end flow:
/task -> awaiting_approval -> /approve -> draft_pr_createdObserved in live run:
awaiting_approvalCommits included
69a7b26fix(manager): close terminal runs after worker failures0ab0fa6feat(telegram): make /task approval-aware695b1a8Add consistent promotion state reconciliation150fc0aAdd promotion step trace summariesRollout note
Please test from branch
codex/pr3-promotion-state-consistencyand do not validate directly onmain.