Use java nio to fix broken symlink

[s0x]

This fixes #164

[srs]

Thanks for the pull. Checking it now ;-)

[cbornet]

Does it work for a npm specified with npmVersion (not bundled with node) ?

[s0x]

That is actually a different issue, which has been resolved by one of the latest versions. This fix does not change any behavior but doesn't use gradles tar plugin which does not support symlinks.

[cbornet]

It's probably another issue but it has not been fixed (see #134) and it has the same initial cause (00cc0c8) so I was hoping it would solve it...

[s0x]

Oh I see ... actually #134 would be fixed by this change

[cbornet]

For the npm bundled with node if I understand well but not for the separately donwloaded npm. Is that correct ?

[s0x]

That's correct. I'll have a look on that tomorrow and try to find a solution for that issue as well

[cbornet]

Cool ! Thanks !

[cbornet]

@s0x Does it also work on Windows ?

[s0x]

This does not change anything on the windows installation, since this is handled separately. Is this broken on windows as well?

[cbornet]

I don't know. I use Linux. But I need it to work on Windows.

[s0x]

Same here.
If there is an issue on windows, please create a issue for that. This discussion does not relate to the MR

[s0x]

@srs: Is there anything which prevents you from merging this?

[srs]

Not sure if this will work on every installation since it's executing the tar command (instead of using the pure-java version). But I assume that tar is always available?

[s0x]

It seems that there is no pure-java version of it. The other option would be to not use the symlink at all. I'm working on it atm.

[s0x]

@srs I fixed the symlink using java nio. I guess that is the best option we have

[srs]

Nice one! Thanks. Now I haven no more concerns. Will pull this tomorrow and a lot of other PR's.