fix(auth): correct OAuth scopes and add missing unstable op#1
Closed
srosenthal-dd wants to merge 1 commit intofix/add-missing-oauth-scopesfrom
Closed
fix(auth): correct OAuth scopes and add missing unstable op#1srosenthal-dd wants to merge 1 commit intofix/add-missing-oauth-scopesfrom
srosenthal-dd wants to merge 1 commit intofix/add-missing-oauth-scopesfrom
Conversation
Scope changes (tested E2E against datad0g.com with OAuth): - Remove ci_visibility_pipelines_write (no pup commands use it) - Remove apm_service_catalog_write (no write commands for service catalog) - Add test_optimization_read (required for cicd tests list/search/aggregate) - Add test_optimization_write (required for cicd flaky-tests update) - Add dora_metrics_write (required for cicd dora patch-deployment) Bugfix: - Add v2.search_flaky_tests to UNSTABLE_OPS (was missing, caused UnstableOperationDisabledError on cicd flaky-tests search) E2E verification (DD_SITE=datad0g.com, OAuth): | Scope | Commands tested | Result | |--------------------------|----------------------------------------------|--------| | ci_visibility_read | cicd pipelines list/get, events search/agg | PASS | | test_optimization_read | cicd tests list/search/aggregate | PASS | | test_optimization_read | cicd flaky-tests search | PASS | | test_optimization_write | cicd flaky-tests update (400, not 403) | PASS | | dora_metrics_write | cicd dora patch-deployment (400, not 403) | PASS | | apm_service_catalog_read | service-catalog list, get | PASS | | teams_read | on-call teams list/get, memberships list | PASS | | teams_manage | on-call teams create/update/delete | PASS | Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
Owner
Author
|
replaced by datadog-labs#155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrections on top of datadog-labs#144 — tested E2E with OAuth against
datad0g.com.Changes
Scopes (
src/auth/types.rs):ci_visibility_pipelines_write(no pup commands use it)apm_service_catalog_write(no write commands for service catalog)test_optimization_read(required forcicd tests list/search/aggregate)test_optimization_write(required forcicd flaky-tests update)dora_metrics_write(required forcicd dora patch-deployment)Bugfix (
src/client.rs):v2.search_flaky_teststoUNSTABLE_OPS(was missing, causedUnstableOperationDisabledError)E2E verification (DD_SITE=datad0g.com, OAuth)
ci_visibility_readcicd pipelines list/get,events search/aggregatetest_optimization_readcicd tests list/search/aggregate,flaky-tests searchtest_optimization_writecicd flaky-tests update(400 not 403)dora_metrics_writecicd dora patch-deployment(400 not 403)apm_service_catalog_readservice-catalog list,service-catalog getteams_readon-call teams list/get,memberships listteams_manageon-call teams create/update/deleteWrite commands that return 400 (bad request body) confirm the scope is working — a scope/auth failure would be 401 or 403.
Known issues (pre-existing, not addressed here)
cicd flaky-tests searchsends an invalid request body (--limitflag is parsed but not passed through)🤖 Generated with Claude Code