Prevent duplicate textures being loaded in displacement map#177
Merged
srmainwaring merged 1 commit intomasterfrom Jan 2, 2025
Merged
Prevent duplicate textures being loaded in displacement map#177srmainwaring merged 1 commit intomasterfrom
srmainwaring merged 1 commit intomasterfrom
Conversation
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the visual plugin attempted to load the height, normal and tangent map textures twice when using displacement map rendering.
There is still an upstream issue in the
GzSceneManager(gz-sim/src/gui/plugins/scene_manager) whereby the visual plugin is loaded twice, causing performance issues, but this change prevents the segmentation fault that caused the GUI to crash.Applies to the
ocean_world.sdfmodel.