Mask passwords while error logging#5
Open
SOVALINUX wants to merge 3 commits intosrinivasupadhya:masterfrom
Open
Mask passwords while error logging#5SOVALINUX wants to merge 3 commits intosrinivasupadhya:masterfrom
SOVALINUX wants to merge 3 commits intosrinivasupadhya:masterfrom
Conversation
Owner
There was a problem hiding this comment.
if i understand this right, you are passing commandLine.toString() as prettyMessage and using it in getMessage(). But isn't that what's happening anyway?
Author
There was a problem hiding this comment.
I saved previous behaviour in method with 4 params and added new one with 5 and pass different prettyMessage only where needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's really awkward when git passwords are shown in logs and on UI while checking connection and checking out the project.
Let's follow common practice and mask them where needed.