add UTF8 locale to build script.So file with nonEnglish chars can be …#52
Merged
srid merged 2 commits intosrid:masterfrom Nov 11, 2025
Merged
add UTF8 locale to build script.So file with nonEnglish chars can be …#52srid merged 2 commits intosrid:masterfrom
srid merged 2 commits intosrid:masterfrom
Conversation
srid
reviewed
Nov 5, 2025
Owner
There was a problem hiding this comment.
https://hackage.haskell.org/package/with-utf8 (blog post) is another way to solve this. Could you try it? Basically, you can wrap the main's body like here:
If this works, you can update the PR accordingly.
Contributor
Author
|
I tried to wrap main with Utf8.withUtf8 without locale variable set in nix build. and still got: withBinaryFile is still not ok with non-ASCII characters in the file names. There is no difference with or without withUtf8 edit: same result with withStdTerminalHandles . |
srid
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this issue
files with None-ASCII charactes could not be generated. add UTF8 locale to nix build script.