Conversation
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
| times = 1 | ||
| } | ||
|
|
||
| // TODO(kyrcha): add a regression.yml file to metadata-retrieval |
There was a problem hiding this comment.
let's postpone merging this PR until regression.yml appears in metadata-retrieval
it is a must
| Name: "metadata-retrieval", | ||
| GitURL: "https://github.com/src-d/metadata-retrieval", | ||
| ProjectPath: "github.com/src-d/metadata-retrieval", | ||
| BinaryName: "cmd", |
There was a problem hiding this comment.
hm, why binary name is cmd?
There was a problem hiding this comment.
hm, this might be a problem taking into account your PR, we should wait for this fix before creating the regression branch.
don't you want to discuss this part with applications team and fix it yourself? this will reduce the waiting time for both of this and regression.yml PRs
test_test.go
Outdated
| // No token, no access to teh v4 API | ||
| config.GitHubToken = os.Getenv("REG_TOKEN") |
There was a problem hiding this comment.
I'm a bit confused about this part:
It probably does parse of the token with right permissions but you replace it with the token from env, that's not set in the CI or elsewhere
I have certainly missed something, could you please clarify it?
There was a problem hiding this comment.
I am doing this assignment because according to the README.md file you have to export REG_TOKEN=your-github-token for this project...so I am doing the assignment here in order to use it in metadataretrieval.go
command := NewCommand(metadataRetrieval.Path, orgs)
start := time.Now()
if err := command.Run(map[string]string{
"LOG_LEVEL": "debug",
"GITHUB_TOKENS": t.config.GitHubToken,
}); err != nil {
t.log.With(log.Fields{
"orgs": orgs,
"metadata-retrieval": metadataRetrieval.Path,
}).Errorf(err, "Could not execute metadata-retrieval")
return nil, err
}
But you are right...it is not set in the .travis.yml, so I added it:
env:
- GO111MODULE=on GOPROXY=https://proxy.golang.org
- REG_TOKEN=$GITHUB_TOKEN
There was a problem hiding this comment.
ah, I see it comes from regression-core's config...
aren't envs should be in one line? because afaik each envs line starts additional job
https://docs.travis-ci.com/user/environment-variables/#defining-multiple-variables-per-item
or am I missing something?
There was a problem hiding this comment.
Nope I have already changed it...tests are passing
| func TestMetadataRetrieval(t *testing.T) { | ||
| config := regression.NewConfig() | ||
| config.BinaryCache = "binaries" | ||
| config.Versions = []string{"remote:master", "v0.1.0"} |
There was a problem hiding this comment.
afaik {"remote:regression", "remote:master"} order is required
reminder: when regression.yml will be added both branches should contain it, so you would possibly need to create
regression branch
There was a problem hiding this comment.
For this I will switch over the conversation to slack.
There was a problem hiding this comment.
I will change the order once everything is created.
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
|
Will need to wait for token upgrade for the tests to pass: https://github.com/src-d/infrastructure/issues/1253 |
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
|
Token upgraded. Tests are passing. For this PR to be merged still waiting for:
|
2 participants
Added support for regression testing the metadata-retrieval command. Mainly a replication of the gitcollector command.
Signed-off-by: Kyriakos Chatzidimitriou kyrcha@gmail.com