-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add Dockerfile #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nfsaavedra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks this is useful. Just two things:
- Can you add a mention to this in the README?
- Ruby needs to be installed so that the parser for Chef works
|
Just updated, feel free to suggest changes. I splitted the instruction in README in two parts INSTALL and USAGE, do you prefer in a different way? |
|
Ah, one more thing, I pushed the image for my dockerhub account: https://hub.docker.com/repository/docker/ruimartinsptl/sr-lab-glitch/general If you create an |
Yes that is a good idea! We'll work on that soon, I'm not sure if there is a |
Nfsaavedra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, I'll merge the PR
No description provided.