fix: improve schema validation so it succeeds for qvolt_hyb_g3_3p inverter #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squishykid
requested changes
Sep 13, 2024
Owner
squishykid
left a comment
squishykid
left a comment
There was a problem hiding this comment.
Hello, thank you for raising this PR. I can see that you are changing the schema and all the tests pass. This is great!
Can you please add some additional tests so your new schema continues working? You will need to capture the response from your inverter and then add a 'InverterUnderTest' like in this example: https://github.com/squishykid/solax/pull/167/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
Author
|
hm, the tests fail but i don't understand how my change could result in this error. any hints? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using this lib now for more than a year and its works well. However, this fix i did here is required to get a successful data validation. I get a validation error when I do not apply it. I just tried it again with the latest master and same problem so here is now a PR to resolve this issue upstream.
Cheers