-
Notifications
You must be signed in to change notification settings - Fork 42
Refactor HTTP clients, fix lyrics plugin #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carl-di-ortus
wants to merge
25
commits into
squentin:master
Choose a base branch
from
carl-di-ortus:5-http
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will not package with level 5, minimum 7 is required, but everything <10 is deprecated.
Bump debian compat level to 10
Add listenbrainz support
add .vscode to .gitignore
Remove duplicate timer removal, fixes non-critical Glib-critical warning
…lete artist events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - I'm rebasing this from #258. It might be easier to review that one first.
My original forked work can be seen here. I have opened a bunch of issues on my forked repository, with the things that bothers me most. I intend to solve them at a slow pace. I might create more PRs in the future, but as of now I don't see a point, as this seems unmaintained.
HTTP client
This PR removes 3 custom HTTP clients, with invisible dependencies (like wget), and replaces it with libxml-perl library calls. Simplified some callbacks. Now forcing all output as utf8.
Lyrics
It also contains a fix for parsing the updated musicmatch.com responses for lyrics plugin. A separate task should be opened to implement more providers or simplify the plugin file, also for bugs in current parser (there are some, like bad url when having '(' ',', ..., wrong h2 tag selected when result contains tags, ...).
Added new feature when response is detected to be instrumental, to write it nicely, in the style as default "No lyrics found" label.
Console output:
Removals
Removed Artist -> Events page, as the endpoint was no longer there.
Summary
This PR closes 3 tasks in my forked repo. It might solve #252, but I haven't tested, and I don't intent to test this. It might also help a little bit with #210, but I haven't check this out, also a relate bug issue is registered in forked repo here.