Skip to content

Delete buggy test that never succeeds #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Salamandar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Delete buggy test that never succeeds #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions plugins/mpris2.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,17 +314,15 @@ sub GetMetadata_from
if (defined $rating && length $rating) { $r{'xesam:userRating'}=dbus_double($rating/100); }
unlink $TEMPCOVERFILE;
if (my $pic= $h{album_picture}) #FIXME use ~album.picture.uri when available
{ if ($pic=~m/$::EmbImage_ext_re(?:\w+)?$/i) #embedded pictures
{ my $ok;
{ last unless defined($::SongID) && $ID==$::SongID; #only support embedded picture for current song
my $data=FileTag::PixFromMusicFile($pic);
last unless $data;
my $fh;
open($fh,'>',$TEMPCOVERFILE) && (print $fh $data) && close($fh) && ($ok=1);
warn "mpris2 plugin, error writing temporary file '".$TEMPCOVERFILE."' for embedded cover: $!" unless $ok;
}
$pic= $ok ? $TEMPCOVERFILE : undef;
{ my $ok;
{ last unless defined($::SongID) && $ID==$::SongID; #only support embedded picture for current song
my $data=FileTag::PixFromMusicFile($pic);
last unless $data;
my $fh;
open($fh,'>',$TEMPCOVERFILE) && (print $fh $data) && close($fh) && ($ok=1);
warn "mpris2 plugin, error writing temporary file '".$TEMPCOVERFILE."' for embedded cover: $!" unless $ok;
}
$pic= $ok ? $TEMPCOVERFILE : undef;
$r{'mpris:artUrl'}= dbus_string( 'file://'.::url_escape($pic) ) if $pic;
}

Expand Down