March 8, `25: Upgraded to THREE r174, examples are all modules in one page

[kellycode]

Required very few changes to upgrade to r174:

updateRange changed to addUpdateRange and
THREE.Math.generateUUID is gone so made SPE.utils.generateUUID

...most of the work was in the examples.

Changed the examples to modules for faster three upgrade testing and made a new BasicScene.js class to simplify the example repetitive scene building, and removed old local dependencies.

I'm upgrading an old project that uses this and that's what got me here. It's a nice particle engine and worth the upgrade time.

Great fun

[squarefeet]

Wow, this is a wonderful surprise, thank you @kellycode!

It's gonna take me a bit of time to go through it, but there are a couple of things I've noticed so far:

1. There are a few folders that have been added, and I'm wondering what they're for: examples/archive and examples/img/Corel Auto-Preserve?
2. There are a bunch of whitespace changes, which is making an initial pass at reviewing this a little tricky. It's my fault for not including any sort of linting, but the main difference in code that hasn't changed logic is the removal of spaces within parentheses. Not a blocker at all, just wanted to point it out!

I've, rather shamefully, let this project languish due to not really having the time to maintain it, so I'm massively appreciative of your efforts here. I'll be going through it properly over the next week, but on first glance, this is super helpful!

[kellycode]

Hi, 1. Those extra folders are just me being reluctant to toss original versions of anything in a working directory. 2. White-space changes are just me letting VSCode format things - no clue how to preserve white-space formatting from a years old project. And tbh, I'm accustomed to doing pull requests for older projects and never hearing back so they're kind of an oops. Got me what I needed and hopefully you find it helpful. Cheers

…

________________________________ From: Luke Moody ***@***.***> Sent: Saturday, March 15, 2025 8:48 AM To: squarefeet/ShaderParticleEngine ***@***.***> Cc: KellyCode ***@***.***>; Mention ***@***.***> Subject: Re: [squarefeet/ShaderParticleEngine] March 8, `25: Upgraded to THREE r174, examples are all modules in one page (PR #155) [squarefeet]squarefeet left a comment (squarefeet/ShaderParticleEngine#155)<#155 (comment)> Wow, this is a wonderful surprise, thank you @kellycode<https://github.com/kellycode>! It's gonna take me a bit of time to go through it, but there are a couple of things I've noticed so far: 1. There are a few folders that have been added, and I'm wondering what they're for: examples/archive and examples/img/Corel Auto-Preserve? 2. There are a bunch of whitespace changes, which is making an initial pass at reviewing this a little tricky. It's my fault for not including any sort of linting, but the main difference in code that hasn't changed logic is the removal of spaces within parentheses. Not a blocker at all, just wanted to point it out! I've, rather shamefully, let this project languish due to not really having the time to maintain it, so I'm massively appreciative of your efforts here. I'll be going through it properly over the next week, but on first glance, this is super helpful! — Reply to this email directly, view it on GitHub<#155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABTBN6M4MC4BADIORM5ENQT2UQVRXAVCNFSM6AAAAABYTNBG26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWGU3DSNJZGM>. You are receiving this because you were mentioned.