[java] Test multisig quorum parameter conditions #713
Merged
+60
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andozw
force-pushed
the
seana.20241121.th1
branch
2 times, most recently
from
d07acf0 to
8f1c11d
Compare
Contributor
|
@andozw did you mean to merge into a non-master branch? |
Contributor
Author
Compare to non-master branch, yes. I created this branch off of the PR that I just merged. And github will automatically update the base branch when it gets merged. |
ivmaykov
previously approved these changes
Dec 2, 2024
Contributor
ivmaykov
left a comment
ivmaykov
left a comment
There was a problem hiding this comment.
LGTM with some questions/comments
java/shared/src/test/java/com/squareup/subzero/shared/SubzeroUtilsTest.java
Outdated
Show resolved
Hide resolved
andozw
force-pushed
the
seana.20241121.testDeriveP2SHP2WSH
branch
2 times, most recently
from
1e344da to
006e746
Compare
Adding tests for the multisig quorum parameter conditions.
andozw
force-pushed
the
seana.20241121.testDeriveP2SHP2WSH
branch
from
006e746 to
92b4797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the multisig quorum parameter conditions.