Add a self-check test for processing a message which exceeds nanopb field size limits #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
6 times, most recently
from
7f515e2 to
6a41ce1
Compare
andozw
previously approved these changes
Apr 21, 2023
Contributor
andozw
left a comment
andozw
left a comment
There was a problem hiding this comment.
Looks good to me. Just a couple of nits and mostly just questions for my own learning.
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
2 times, most recently
from
a990dd0 to
d1c3725
Compare
oreparaz
reviewed
Apr 24, 2023
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
2 times, most recently
from
92b5bfd to
68be7dd
Compare
oreparaz
previously approved these changes
May 2, 2023
Collaborator
oreparaz
left a comment
oreparaz
left a comment
There was a problem hiding this comment.
Nice work, there's a conflict with core/CMakeLists.txt so happy to re stamp if needed.
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
from
68be7dd to
d7a10dc
Compare
Contributor
Author
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
from
d7a10dc to
fec311f
Compare
Contributor
Author
|
Squished all 4 commits together |
ivmaykov
force-pushed
the
rpc-oversized-message-check
branch
from
fec311f to
eae5fa4
Compare
oreparaz
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This verifies that nanopb refuses to parse such messages, rather than blowing the stack.