Fix typo in exception name when JLINKARM_SelectUSB fails#258
Merged
hkpeprah merged 2 commits intosquare:masterfrom Feb 23, 2026
Merged
Fix typo in exception name when JLINKARM_SelectUSB fails#258hkpeprah merged 2 commits intosquare:masterfrom
JLINKARM_SelectUSB fails#258hkpeprah merged 2 commits intosquare:masterfrom
Conversation
|
|
hkpeprah
previously approved these changes
Feb 21, 2026
Contributor
hkpeprah
left a comment
hkpeprah
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this.
Contributor
|
Looks like the tests are failing. |
Contributor
Author
|
|
due to recent typo fix, the `JLinkException` is raised, but tests were catching `AttributeError`
Contributor
Author
|
Fixed. Those tests had wrong expectations and worked thanks to the previous typo. I will verify that all tests pass before pushing my changes, sorry. |
hkpeprah
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mentioned in #254
I know, a single line PR, but it is pretty straightforward.