Switch tooling to uv, ruff, and just
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notenti
approved these changes
Dec 20, 2024
.github/workflows/test.yml
Outdated
Comment on lines
19
to
24
| - run: uv run -p ${{ matrix.python-version}} black pyfu_usb/ tests/ | ||
| - run: uv run -p ${{ matrix.python-version}} mypy pyfu_usb/ tests/ | ||
| - run: uv run -p ${{ matrix.python-version}} pylint pyfu_usb/ tests/ | ||
| - run: uv run -p ${{ matrix.python-version}} isort pyfu_usb/ tests/ | ||
| - run: uv run -p ${{ matrix.python-version}} pytest tests/ | ||
| - run: uv build -p ${{ matrix.python-version }} |
Collaborator
There was a problem hiding this comment.
nit/suggestion: probably can use ruff instead of isort and black, too
Collaborator
Author
There was a problem hiding this comment.
Good call, probably can replace pylint as well. Will make that change.
…ersion, since there are source code changes. This will also allow us to test the changes to the publish pipeline.
bbrown1867
changed the title
uv and justuv, ruff, and just
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain the changes you made here.
This PR updates the repo to use
uvfor Python tooling, instead ofsetuptools. It also usesjustto automate some commands. Benefits:venvin theMakefilegoes away, sinceuvhandles all of this for us.setup.pycan be consolidated withpyproject.toml.astral-sh/setup-uv@v3anduv run -pfor multi-Python version testing.pyproject.toml.Does this close any currently open issues?
No.
Checklist: