This repository was archived by the owner on Apr 30, 2019. It is now read-only.
adding ability to detect handlers from super class. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We're just going to enable this for all types by default. Opt-in not necessary. See #135. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handler class is annotated with @InheritSubscribers during registration all DECLARED handler methods from super class will be added to subscribers list. Handled methods from superclass's superclass
will not be added unless it also has @InheritSubscribers annotation.
As this functionality is explicitly requested by the user by placing InheritSubscribers annotation,
user cannot complain on performance and code complexity.