This repository was archived by the owner on Oct 10, 2024. It is now read-only.
feat: $V for inlined values in generated code#999
Open
Christopher-Chianelli wants to merge 2 commits intosquare:masterfrom
Open
feat: $V for inlined values in generated code#999Christopher-Chianelli wants to merge 2 commits intosquare:masterfrom
Christopher-Chianelli wants to merge 2 commits intosquare:masterfrom
Conversation
If you have an instance you want to put inside the generated code, and you trust it, you can use the new "$V" argument spec to tell JavaPoet to generate a Supplier lambda to construct the object and immediately call it.
This was referenced Feb 10, 2024
Previously, if multiple threads were inlining using the same ObjectInliner, the internal state of the inliner would be corrupted. This is fixed by creating a new ObjectEmitter whenever a value is being inlined; the ObjectEmitters created from an ObjectInliner are completely independent and thus cannot be corrupted by multithreaded use. Also undos the unneccessary NameAllocator change, update the API for TypeInliner, and adds more tests for custom inlining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have an instance you want to put inside
the generated code, and you trust it, you can
use the new "$V" argument spec to tell JavaPoet
to generate a Supplier lambda to construct the
object and immediately call it.
Design questions:
$Van appropriate name for the argument spec?Class.getName. However, since this project uses Java 8, it is hard to add a test for it. This can be removed; a user could add their own Record inliner if needed usingaddTypeInliner.Closes #968