This repository was archived by the owner on Oct 10, 2024. It is now read-only.
addModifiers method in FieldSpec and TypeSpec accepting Iterable#901
Open
homedirectory wants to merge 1 commit intosquare:masterfrom
Open
addModifiers method in FieldSpec and TypeSpec accepting Iterable#901homedirectory wants to merge 1 commit intosquare:masterfrom
homedirectory wants to merge 1 commit intosquare:masterfrom
Conversation
…accepts an Iterable type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
FieldSpecandTypeSpecboth haveaddModifiersmethod that accepts a variable number of arguments of typeModifier:In contrast,
MethodSpechas an additional convenient signature for this method that accepts aIterabletype:I think it is appropriate to enhance
FieldSpecandTypeSpecto also have such method signature.