Skip to content
This repository was archived by the owner on Oct 10, 2024. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/com/squareup/javapoet/TypeSpec.java
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,19 @@ public Builder addModifiers(Modifier... modifiers) {
Collections.addAll(this.modifiers, modifiers);
return this;
}
/**
* This is addModifier version for Iterable input.

* @return Builder
*/
//CS304 Issue link: https://github.com/square/javapoet/issues/841
public Builder addModifiers(Iterable<Modifier> modifiers){
checkNotNull(modifiers, "modifiers == null");
for (Modifier modifier : modifiers){
this.modifiers.add(modifier);
}
return this;
}

public Builder addTypeVariables(Iterable<TypeVariableName> typeVariables) {
checkArgument(typeVariables != null, "typeVariables == null");
Expand Down
18 changes: 18 additions & 0 deletions src/test/java/com/squareup/javapoet/TypeSpecTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1999,6 +1999,24 @@ private String toString(TypeSpec typeSpec) {
.isEqualTo("modifiers contain null");
}
}
//CS304 (manually written) Issue link: https://github.com/square/javapoet/issues/841
@Test public void ModifiersListAdditions(){
Modifier[] modifiers = {Modifier.PUBLIC, Modifier.FINAL};
TypeSpec.Builder builder =
TypeSpec.classBuilder("Taco").addModifiers(modifiers);

assertThat(builder.build().modifiers).containsExactly(Modifier.PUBLIC, Modifier.FINAL);
}
//CS304 (manually written) Issue link: https://github.com/square/javapoet/issues/841
@Test public void nullModifiersListAdditions(){
try {
TypeSpec.classBuilder("Taco")
.addModifiers((Iterable<Modifier>) null).build();
fail();
} catch (NullPointerException e) {
assertThat(e.getMessage()).isEqualTo("modifiers == null");
}
}

@Test public void nullTypeVariablesAddition() {
try {
Expand Down