Allow explicitly set identifiers on all systems

[antons]

I’m working on a suite of iOS and macOS apps that are going to share login information using iCloud Keychain. The apps will be distributed both on the App Store and directly, signed with Developer ID. As discussed in #140, switching between a directly distributed app and an App Store release shows a keychain prompt with the service identifier, so we have to use an explicitly set identifier. Since the items are synchronizable, we need to use the same explicitly set identifier on iOS. Currently Valet prevents this by restricting the explicitly set identifier APIs to macOS only. Would you be open to allowing the explicitly set identifier APIs on all systems? Ideally, I’d prefer to avoid maintaining a fork.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[dfed]

That seems reasonable to me! Thanks for sharing your reasoning. The documentation on these methods is reasonable regarding the downsides of using it. I'd like to add an addendum to Creates a Valet with an explicitly set kSecAttrService. along the lines of This API is intended for use with macOS applications where service identifiers can be user-facing.

Sound reasonable?

[antons]

Yep, sounds reasonable! Updated, and fixed watchOS.

[dfed]

Looking good @antons! Once the CLA is signed (and I'm awake – it's getting late here) I'll merge + publish a release.

[antons]

@dfed I have submitted the CLA shortly after submitting the PR, and I’m not sure why it hasn’t registered. FYI, once this merges, I will have another pull request extending #297 to Valets with explicit identifiers.

[dfed]

@efirestone can you lend a hand with the CLA bot?

[dfed]

@pwesten aimilar ask: would love some insight into the ClA check failure given the above – @antons said they signed it.

[dfed]

@bmaddox any chance of an assist?