[RST-27240] Fixes unexpected cell animation bug

[rpeel-sq]

Reverts #542, to fix unexpected cell animation bug.

Demo

Before

before.mov

After

after.mov

Checklist

Please do the following before merging:

• Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

[johnnewman-square]

Based on our discussion in Slack, I think we can make this tweak official! It would be great if we had a demo that showcased the fixed behavior, where the call to:

UIView.performWithoutAnimation {
    cell.layoutIfNeeded()
}

showed animations no longer running.

[johnnewman-square]

This looks good! I'm going to ask the team for one additional review around the github workflow changes and whether or not we need aria2.

[robmaceachern]

I'm going to ask the team for one additional review around the github workflow changes and whether or not we need aria2.

I think aria2 will still be used implicitly in the following step so probably worth keeping around. You might be able to find some hints buried in the build logs but I guess the best way to verify would be to spin up a PR without it and compare the total CI times.

[johnnewman-square]

Thanks @robmaceachern! This draft PR removed aria2 and CI took 5m 51s. That seems to match previous results, but I'm on board with keeping it around if we'd like to minimize the changes here.

[robmaceachern]

Yeah it looks like it's either not being used or makes no real difference. Probably fine to remove!

[robmaceachern]

Oh actually I just noticed this:

So it might be that just removing the install step doesn't necessarily mean that aria2 won't already be installed on the machine. Not sure if github includes it or the runner was cached or something else.

[rpeel-sq]

So should I remove or leave 😅?

[robmaceachern]

Haha just leave it 👍🏽