Skip to content

Conversation

@meherkasam-square
Copy link
Collaborator

@meherkasam-square meherkasam-square commented Jun 18, 2025

Migrated local build and CI to tuist and removed CocoaPods entirely.

Checklist

Please do the following before merging:

  • Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

@meherkasam-square meherkasam-square force-pushed the meher/tuist branch 2 times, most recently from 21b13fb to fcaa1df Compare June 20, 2025 04:07
@meherkasam-square meherkasam-square force-pushed the meher/tuist branch 10 times, most recently from bc07d6d to 3b2dba0 Compare June 27, 2025 00:05
@meherkasam-square meherkasam-square force-pushed the meher/tuist branch 7 times, most recently from 587b880 to 6e12013 Compare July 7, 2025 19:25
@meherkasam-square meherkasam-square self-assigned this Jul 7, 2025
@meherkasam-square meherkasam-square marked this pull request as ready for review July 7, 2025 19:26
Copy link
Contributor

@johnnewman-square johnnewman-square left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really nice to see Tuist replacing CocoaPods and its demo setup! 👏

I left some comments around Bundle extension tweaks that we can make, along with some Tuist updates to begin pulling in the test targets.

@meherkasam-square meherkasam-square force-pushed the meher/tuist branch 3 times, most recently from ed87cb5 to e87a11b Compare July 15, 2025 10:50
Copy link
Contributor

@johnnewman-square johnnewman-square left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well, nice work! There are a few final items that I wanted to iron out before merging:

  • The IdentifierChangedViewController is missing imports to Foundation and UIKit. This controller was just merged into main.
  • Scripts/generate_docs.sh is having issues finding the ListableUI scheme.
  • There is a Snapshot-Unit-Tests target in Listable's main branch with a few unit tests for the internal library. We might want to pull that into Tuist as well.

Copy link
Contributor

@johnnewman-square johnnewman-square left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making those updates.

Copy link
Collaborator

@watt watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some work remaining to ensure tests run and docs can still be generated, looks good overall though.

Copy link
Collaborator

@watt watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend getting CI to run tuist generate and tuist test without any calls to xcodebuild. Otherwise LGTM. 👍

@meherkasam-square meherkasam-square merged commit 13a2095 into square:main Jul 23, 2025
3 checks passed
@meherkasam-square meherkasam-square mentioned this pull request Jul 23, 2025
1 task
kyleve added a commit that referenced this pull request Jul 24, 2025
…-headerfooters

* origin/main:
  build: set up tuist (#584)
  Bumping versions to 16.3.0 (#589)
  Reset scroll position if list identifier changes (#588)
  Bumping versions to 16.2.0 (#587)
  Adding a completion handler to the `scrollToSection` API. (#585)
  Adding a programmatic scroll completion handler (#582)
  Remove iOS 19 (26) cap of the collection view first responder workaround (#581)
  Bumping versions to 16.1.0 (#583)
  Update for Blueprint 6.0.0 (#580)
  Bumping versions to 16.0.4. (#579)
  Update the first responder resignation workaround to be enabled by default and cap at < iOS 19 [UI-8849] (#578)
  Bumping versions to 16.0.3 (#577)
  Bottom gravity and autoscroll improvements (#576)
  Bumping versions to 16.0.2 (#574)
  Addressing an AutoScrollAction issue when using VerticalLayoutGravity.bottom (#572)
  release: Prepare 16.0.1 release (#569)
  Fix reordering crash introduced in 16.0 (#568)
meherkasam-square added a commit that referenced this pull request Jul 24, 2025
Fast-follow items from
[this](#584) PR

### Checklist

Please do the following before merging:

- [X] Ensure any public-facing changes are reflected in the
[changelog](https://github.com/square/Listable/blob/main/CHANGELOG.md).
Include them in the `Main` section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants