-
Notifications
You must be signed in to change notification settings - Fork 33
build: set up tuist #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set up tuist #584
Conversation
21b13fb to
fcaa1df
Compare
bc07d6d to
3b2dba0
Compare
587b880 to
6e12013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really nice to see Tuist replacing CocoaPods and its demo setup! 👏
I left some comments around Bundle extension tweaks that we can make, along with some Tuist updates to begin pulling in the test targets.
ed87cb5 to
e87a11b
Compare
johnnewman-square
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well, nice work! There are a few final items that I wanted to iron out before merging:
- The
IdentifierChangedViewControlleris missing imports toFoundationandUIKit. This controller was just merged intomain. Scripts/generate_docs.shis having issues finding theListableUIscheme.- There is a
Snapshot-Unit-Teststarget in Listable's main branch with a few unit tests for the internal library. We might want to pull that into Tuist as well.
e87a11b to
698d47d
Compare
johnnewman-square
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for making those updates.
a29a804 to
1b93d6c
Compare
watt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some work remaining to ensure tests run and docs can still be generated, looks good overall though.
1b93d6c to
2c12973
Compare
Development/Derived/InfoPlists/BlueprintUIListsTests-Info.plist
Outdated
Show resolved
Hide resolved
Development/ListableDevelopment.xcworkspace/contents.xcworkspacedata
Outdated
Show resolved
Hide resolved
2c12973 to
af556a1
Compare
watt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend getting CI to run tuist generate and tuist test without any calls to xcodebuild. Otherwise LGTM. 👍
…-headerfooters * origin/main: build: set up tuist (#584) Bumping versions to 16.3.0 (#589) Reset scroll position if list identifier changes (#588) Bumping versions to 16.2.0 (#587) Adding a completion handler to the `scrollToSection` API. (#585) Adding a programmatic scroll completion handler (#582) Remove iOS 19 (26) cap of the collection view first responder workaround (#581) Bumping versions to 16.1.0 (#583) Update for Blueprint 6.0.0 (#580) Bumping versions to 16.0.4. (#579) Update the first responder resignation workaround to be enabled by default and cap at < iOS 19 [UI-8849] (#578) Bumping versions to 16.0.3 (#577) Bottom gravity and autoscroll improvements (#576) Bumping versions to 16.0.2 (#574) Addressing an AutoScrollAction issue when using VerticalLayoutGravity.bottom (#572) release: Prepare 16.0.1 release (#569) Fix reordering crash introduced in 16.0 (#568)
Fast-follow items from [this](#584) PR ### Checklist Please do the following before merging: - [X] Ensure any public-facing changes are reflected in the [changelog](https://github.com/square/Listable/blob/main/CHANGELOG.md). Include them in the `Main` section.
Migrated local build and CI to tuist and removed CocoaPods entirely.
Checklist
Please do the following before merging:
Mainsection.