Skip to content

Conversation

@dalthviz
Copy link
Member

@dalthviz dalthviz commented Oct 28, 2025

Description of Changes

Issue(s) Resolved

Fixes #25195

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v6.1.1 milestone Oct 28, 2025
@dalthviz dalthviz self-assigned this Oct 28, 2025
@dalthviz dalthviz changed the title [WIP] PR: Update python-lsp-server subrepo (flake8 cmd on Windows fix) PR: Update python-lsp-server subrepo (flake8 cmd on Windows fix) Oct 29, 2025
@dalthviz dalthviz marked this pull request as ready for review October 29, 2025 18:38
@dalthviz
Copy link
Member Author

Note: To test how the changes over python-lsp-server affect Spyder try running from the cmd on Windows with pythonw bootstrap.py setting as linting provider flake8. From master you will see the cmd windows. From this PR branch no cmd windows should be shown

@dalthviz dalthviz requested a review from ccordoba12 October 29, 2025 18:40
@ccordoba12
Copy link
Member

@dalthviz, please remove your commit and simply resync the pylsp subrepo with

git subrepo pull external-deps/python-lsp-server

so that I can merge this one now that python-lsp/python-lsp-server#683 is merged.

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "6a2432689"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "6a2432689"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 2fe8548 into spyder-ide:master Oct 31, 2025
20 checks passed
ccordoba12 added a commit that referenced this pull request Oct 31, 2025
Backport PR #25247 on branch 6.x (PR: Update python-lsp-server subrepo (flake8 cmd on Windows fix))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After enabling the Flake8 option, a large number of cmd.exe windows keep appearing

2 participants