Fix return annotation type #7
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
After I updated the package in a Spryker application, PHPStan informed me that the return type does not match the one from the Spryker project.
As the format of the array is described in the project itself, I want to update the annotation to the correct type.
The updated docblock from the
getWhitelistForAllowedAttributeValueChanges()method will match these array format.At least the docblock fix should make it into the master branch. The typhint is a nice-to-have in my opinion.
Checklist