Fix Content model social_media_provider validation#17
Merged
Conversation
Remove contradictory allow_blank: true from social_media_provider validation. The field is required per business requirements, so the presence validation should not be undermined by allow_blank. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
allow_blank: truefromsocial_media_providervalidationProblem
The Content model had conflicting validation rules:
validates :social_media_provider, presence: true(required)validates :social_media_provider, inclusion: { in: social_media_providers.keys }, allow_blank: true(allows blank)The
allow_blank: trueoption contradicted the business requirement thatsocial_media_provideris a required field.Solution
Merged the two validations into a single rule:
This ensures the field is both required and restricted to valid enum values (instagram, tiktok, youtube).