Skip to content

Apply fixes from CodeFactor#15

Closed
codefactor-io[bot] wants to merge 1 commit intomainfrom
main-cf-autofix
Closed

Apply fixes from CodeFactor#15
codefactor-io[bot] wants to merge 1 commit intomainfrom
main-cf-autofix

Conversation

@codefactor-io
Copy link

@codefactor-io codefactor-io bot commented Mar 4, 2026

This pull request applies fixes from code review by CodeFactor.


For more information, click here.

t.index ["created_at"], name: "index_solid_cable_messages_on_created_at"
create_table 'solid_cable_messages', force: :cascade do |t|
t.binary 'channel', limit: 1024, null: false
t.binary 'payload', limit: 536870912, null: false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use underscores(_) as thousands separator and separate every 3 digits with them.

Suggested change
t.binary 'payload', limit: 536870912, null: false
t.binary 'payload', limit: 536_870_912, null: false

t.index ["key_hash"], name: "index_solid_cache_entries_on_key_hash", unique: true
create_table 'solid_cache_entries', force: :cascade do |t|
t.binary 'key', limit: 1024, null: false
t.binary 'value', limit: 536870912, null: false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use underscores(_) as thousands separator and separate every 3 digits with them.

Suggested change
t.binary 'value', limit: 536870912, null: false
t.binary 'value', limit: 536_870_912, null: false

t.integer 'key_hash', limit: 8, null: false
t.integer 'byte_size', limit: 4, null: false
t.index ['byte_size'], name: 'index_solid_cache_entries_on_byte_size'
t.index ['key_hash', 'byte_size'], name: 'index_solid_cache_entries_on_key_hash_and_byte_size'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index ['key_hash', 'byte_size'], name: 'index_solid_cache_entries_on_key_hash_and_byte_size'
t.index %w[key_hash byte_size], name: 'index_solid_cache_entries_on_key_hash_and_byte_size'

t.string 'concurrency_key', null: false
t.datetime 'expires_at', null: false
t.datetime 'created_at', null: false
t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release'
t.index %w[concurrency_key priority job_id], name: 'index_solid_queue_blocked_executions_for_release'

t.datetime 'expires_at', null: false
t.datetime 'created_at', null: false
t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release'
t.index [ 'expires_at', 'concurrency_key' ], name: 'index_solid_queue_blocked_executions_for_maintenance'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'expires_at', 'concurrency_key' ], name: 'index_solid_queue_blocked_executions_for_maintenance'
t.index %w[expires_at concurrency_key], name: 'index_solid_queue_blocked_executions_for_maintenance'

t.datetime 'created_at', null: false
t.index [ 'job_id' ], name: 'index_solid_queue_ready_executions_on_job_id', unique: true
t.index [ 'priority', 'job_id' ], name: 'index_solid_queue_poll_all'
t.index [ 'queue_name', 'priority', 'job_id' ], name: 'index_solid_queue_poll_by_queue'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'queue_name', 'priority', 'job_id' ], name: 'index_solid_queue_poll_by_queue'
t.index %w[queue_name priority job_id], name: 'index_solid_queue_poll_by_queue'

t.datetime 'run_at', null: false
t.datetime 'created_at', null: false
t.index [ 'job_id' ], name: 'index_solid_queue_recurring_executions_on_job_id', unique: true
t.index [ 'task_key', 'run_at' ], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'task_key', 'run_at' ], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true
t.index %w[task_key run_at], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true

t.datetime 'scheduled_at', null: false
t.datetime 'created_at', null: false
t.index [ 'job_id' ], name: 'index_solid_queue_scheduled_executions_on_job_id', unique: true
t.index [ 'scheduled_at', 'priority', 'job_id' ], name: 'index_solid_queue_dispatch_all'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'scheduled_at', 'priority', 'job_id' ], name: 'index_solid_queue_dispatch_all'
t.index %w[scheduled_at priority job_id], name: 'index_solid_queue_dispatch_all'

t.datetime 'created_at', null: false
t.datetime 'updated_at', null: false
t.index [ 'expires_at' ], name: 'index_solid_queue_semaphores_on_expires_at'
t.index [ 'key', 'value' ], name: 'index_solid_queue_semaphores_on_key_and_value'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %w or %W for an array of words.

Suggested change
t.index [ 'key', 'value' ], name: 'index_solid_queue_semaphores_on_key_and_value'
t.index %w[key value], name: 'index_solid_queue_semaphores_on_key_and_value'


# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem "tzinfo-data", platforms: %i[ windows jruby ]
gem 'tzinfo-data', platforms: %i[ windows jruby ]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use spaces inside percent literal delimiters.

Suggested change
gem 'tzinfo-data', platforms: %i[ windows jruby ]
gem 'tzinfo-data', platforms: %i[windows jruby]

@springwq springwq closed this Mar 4, 2026
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/controllers/contents_controller.rb 0.00% 3 Missing ⚠️
app/helpers/application_helper.rb 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants