Conversation
| t.index ["created_at"], name: "index_solid_cable_messages_on_created_at" | ||
| create_table 'solid_cable_messages', force: :cascade do |t| | ||
| t.binary 'channel', limit: 1024, null: false | ||
| t.binary 'payload', limit: 536870912, null: false |
There was a problem hiding this comment.
Use underscores(_) as thousands separator and separate every 3 digits with them.
| t.binary 'payload', limit: 536870912, null: false | |
| t.binary 'payload', limit: 536_870_912, null: false |
| t.index ["key_hash"], name: "index_solid_cache_entries_on_key_hash", unique: true | ||
| create_table 'solid_cache_entries', force: :cascade do |t| | ||
| t.binary 'key', limit: 1024, null: false | ||
| t.binary 'value', limit: 536870912, null: false |
There was a problem hiding this comment.
Use underscores(_) as thousands separator and separate every 3 digits with them.
| t.binary 'value', limit: 536870912, null: false | |
| t.binary 'value', limit: 536_870_912, null: false |
| t.integer 'key_hash', limit: 8, null: false | ||
| t.integer 'byte_size', limit: 4, null: false | ||
| t.index ['byte_size'], name: 'index_solid_cache_entries_on_byte_size' | ||
| t.index ['key_hash', 'byte_size'], name: 'index_solid_cache_entries_on_key_hash_and_byte_size' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index ['key_hash', 'byte_size'], name: 'index_solid_cache_entries_on_key_hash_and_byte_size' | |
| t.index %w[key_hash byte_size], name: 'index_solid_cache_entries_on_key_hash_and_byte_size' |
| t.string 'concurrency_key', null: false | ||
| t.datetime 'expires_at', null: false | ||
| t.datetime 'created_at', null: false | ||
| t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release' | |
| t.index %w[concurrency_key priority job_id], name: 'index_solid_queue_blocked_executions_for_release' |
| t.datetime 'expires_at', null: false | ||
| t.datetime 'created_at', null: false | ||
| t.index [ 'concurrency_key', 'priority', 'job_id' ], name: 'index_solid_queue_blocked_executions_for_release' | ||
| t.index [ 'expires_at', 'concurrency_key' ], name: 'index_solid_queue_blocked_executions_for_maintenance' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'expires_at', 'concurrency_key' ], name: 'index_solid_queue_blocked_executions_for_maintenance' | |
| t.index %w[expires_at concurrency_key], name: 'index_solid_queue_blocked_executions_for_maintenance' |
| t.datetime 'created_at', null: false | ||
| t.index [ 'job_id' ], name: 'index_solid_queue_ready_executions_on_job_id', unique: true | ||
| t.index [ 'priority', 'job_id' ], name: 'index_solid_queue_poll_all' | ||
| t.index [ 'queue_name', 'priority', 'job_id' ], name: 'index_solid_queue_poll_by_queue' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'queue_name', 'priority', 'job_id' ], name: 'index_solid_queue_poll_by_queue' | |
| t.index %w[queue_name priority job_id], name: 'index_solid_queue_poll_by_queue' |
| t.datetime 'run_at', null: false | ||
| t.datetime 'created_at', null: false | ||
| t.index [ 'job_id' ], name: 'index_solid_queue_recurring_executions_on_job_id', unique: true | ||
| t.index [ 'task_key', 'run_at' ], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'task_key', 'run_at' ], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true | |
| t.index %w[task_key run_at], name: 'index_solid_queue_recurring_executions_on_task_key_and_run_at', unique: true |
| t.datetime 'scheduled_at', null: false | ||
| t.datetime 'created_at', null: false | ||
| t.index [ 'job_id' ], name: 'index_solid_queue_scheduled_executions_on_job_id', unique: true | ||
| t.index [ 'scheduled_at', 'priority', 'job_id' ], name: 'index_solid_queue_dispatch_all' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'scheduled_at', 'priority', 'job_id' ], name: 'index_solid_queue_dispatch_all' | |
| t.index %w[scheduled_at priority job_id], name: 'index_solid_queue_dispatch_all' |
| t.datetime 'created_at', null: false | ||
| t.datetime 'updated_at', null: false | ||
| t.index [ 'expires_at' ], name: 'index_solid_queue_semaphores_on_expires_at' | ||
| t.index [ 'key', 'value' ], name: 'index_solid_queue_semaphores_on_key_and_value' |
There was a problem hiding this comment.
Use %w or %W for an array of words.
| t.index [ 'key', 'value' ], name: 'index_solid_queue_semaphores_on_key_and_value' | |
| t.index %w[key value], name: 'index_solid_queue_semaphores_on_key_and_value' |
|
|
||
| # Windows does not include zoneinfo files, so bundle the tzinfo-data gem | ||
| gem "tzinfo-data", platforms: %i[ windows jruby ] | ||
| gem 'tzinfo-data', platforms: %i[ windows jruby ] |
There was a problem hiding this comment.
Do not use spaces inside percent literal delimiters.
| gem 'tzinfo-data', platforms: %i[ windows jruby ] | |
| gem 'tzinfo-data', platforms: %i[windows jruby] |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This pull request applies fixes from code review by CodeFactor.
For more information, click here.