Updating build locally, docker-compose, and kubernetes#3
Open
osamamagdy wants to merge 49 commits intospringframeworkguru:masterfrom
Open
Updating build locally, docker-compose, and kubernetes#3osamamagdy wants to merge 49 commits intospringframeworkguru:masterfrom
osamamagdy wants to merge 49 commits intospringframeworkguru:masterfrom
Conversation
Create pipeline.yml
Create main.yml
Terraform is intended to provision cloud infrastructure using the IaaC approach. This file creates a cloud computing instance on GCP with a boot disk of 20 GB size and an additional 100 GB disk locally attached to it to store data
Make modifications to the README.md file and the terraform file ignored by github actions as they don't contribute to the building process
Author
|
@mfarid @springframeworkguru Can you review those changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @springframeworkguru,
I hope you are doing great. I was asked recently to dockerize one of your spring-boot applications but I had some troubles while trying to build it even locally (I think this may be due to old versioning and lack of a detailed readme). So, I tried my best to solve all the issues I faced and tested everything to make sure it is working. I also used Docker, docker-compose, and Kubernetes which was never here, and explained all the steps to run them in the readme. You can refer to the changes I made and if you like it, I will be honored to contribute and merge these changes.
Regards,