Record remoteAddress in unmapped mapper
#101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @evisong, Thanks for your PRs! I'll try to have a look at them as soon as possible. |
Author
Hi, @josebolos, May I ask if there is any progress yet? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, team,
In my use case,
remoteAddresshelps a lot when analyzing beacons. It seems this argument is passed intomapfunction but it's never used yet: https://github.com/springernature/boomcatch/blob/master/src/index.js#L656I'm adding it to unmapped mapper.
Could you kindly let me know if it's proper to do so, and if yes whether should I add to other mappers as well?
Thanks.