Appended newline to data in file forwarder #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evisong
commented
Sep 28, 2018
| fs.writeFile( | ||
| path.join(directory, 'boomcatch-' + uuid.v4() + '.' + extensions[type || 'default']), | ||
| data, | ||
| data + '\n', |
Author
There was a problem hiding this comment.
This is common in *nix, please let me know if I should use require('os').EOL instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, team,
I've been using Boomcatch together with ELK stacks, my solution depends on unmapped mapper and file forwarder, and then let FileBeat to collect generated json files. However FileBeat doesn't recognize any record if a json file doesn't end with newline (
\n).When I read Boomcatch source code, I think I could append the newline (
\n) to the end ofdatain file forwarder, and I guess it won't break any downstream usages.I've also adjusted UT.
Could you please help review this PR?
Thanks.