Skip to content

[refactor] 이벤트 참여 DB 락 로직 수정 #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3uomlkh merged 2 commits into from
May 27, 2025
Merged

[refactor] 이벤트 참여 DB 락 로직 수정 #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e58f16
refactor(event): Event 엔티티에 참여 가능 인원 필드 추가 #288
3uomlkh May 20, 2025
65ef94b
refactor(event): 이벤트 참가 가능 인원 체크를 도메인 메서드로 변경 #288
3uomlkh May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/main/java/org/example/tablenow/domain/event/entity/Event.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public class Event extends TimeStamped {
@Column(nullable = false)
private int limitPeople;

@Column(nullable = false)
private int availableSeats;

@Enumerated(EnumType.STRING)
@Column(nullable = false)
private EventStatus status;
Expand All @@ -55,13 +58,25 @@ private Event(Store store, String content, LocalDateTime openAt, LocalDateTime e
this.endAt = endAt;
this.eventTime = eventTime;
this.limitPeople = limitPeople;
this.availableSeats = limitPeople;
this.status = EventStatus.READY;
}

public void update(LocalDateTime openAt, LocalDateTime eventTime, Integer limitPeople) {
if (openAt != null) this.openAt = openAt;
if (eventTime != null) this.eventTime = eventTime;
if (limitPeople != null) this.limitPeople = limitPeople;
if (limitPeople != null) {
this.limitPeople = limitPeople;
this.availableSeats = limitPeople;
}
}

public void decreaseAvailableSeats() {
if (this.availableSeats > 0) {
this.availableSeats--;
} else {
throw new HandledException(ErrorCode.EVENT_FULL);
}
}

public boolean isReady() {
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/example/tablenow/domain/event/repository/EventRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,16 @@
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Lock;
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.query.Param;

import java.time.LocalDateTime;
import java.util.Optional;

public interface EventRepository extends JpaRepository<Event, Long> {
boolean existsByStore_IdAndEventTime(Long storeId, LocalDateTime eventTime);
Page<Event> findByStatus(EventStatus status, Pageable pageable);

@Lock(LockModeType.PESSIMISTIC_WRITE)
@Query("SELECT e FROM Event e WHERE e.id = :id")
Optional<Event> findByIdForUpdate(Long id);
Optional<Event> findByIdForUpdate(@Param("id") Long id);
}
5 changes: 2 additions & 3 deletions src/main/java/org/example/tablenow/domain/event/service/EventJoinService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ public EventJoinResponseDto joinEventWithDBLock(Long eventId, AuthUser authUser)
throw new HandledException(ErrorCode.EVENT_ALREADY_JOINED);
}

if (eventJoinRepository.countByEvent(event) >= event.getLimitPeople()) {
throw new HandledException(ErrorCode.EVENT_FULL);
}
event.decreaseAvailableSeats();
eventRepository.save(event);

EventJoin eventJoin = EventJoin.builder()
.user(user)
Expand Down