Skip to content

[refactor] 더티 체킹 제거 및 명시적 저장 방식으로 리팩토링 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshshsh merged 1 commit into from
May 2, 2025
Merged

[refactor] 더티 체킹 제거 및 명시적 저장 방식으로 리팩토링 #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/org/example/tablenow/domain/notification/service/NotificationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.example.tablenow.domain.store.entity.Store;
import org.example.tablenow.domain.store.service.StoreService;
import org.example.tablenow.domain.user.entity.User;
import org.example.tablenow.domain.user.repository.UserRepository;
import org.example.tablenow.domain.user.service.UserService;
import org.example.tablenow.domain.waitlist.entity.Waitlist;
import org.example.tablenow.domain.waitlist.repository.WaitlistRepository;
Expand All @@ -38,6 +39,7 @@ public class NotificationService {
private final WaitlistRepository waitlistRepository;
private final StringRedisTemplate stringRedisTemplate;
private final ObjectMapper objectMapper;
private final UserRepository userRepository;

private static final Duration CACHE_TTL = Duration.ofMinutes(10);
private static final String CACHE_PREFIX = "notifications:";
Expand All @@ -55,6 +57,8 @@ public NotificationResponseDto createNotification(NotificationRequestDto request
if (NotificationType.VACANCY.equals(requestDto.getType())) {
handleVacancyNotification(findUser, requestDto.getStoreId());
}
stringRedisTemplate.delete(CACHE_PREFIX + requestDto.getUserId());


return NotificationResponseDto.fromNotification(savedNotification);
}
Expand Down Expand Up @@ -114,6 +118,7 @@ public NotificationUpdateReadResponseDto updateNotificationRead(Long notificatio
}

findNotification.updateRead();
notificationRepository.save(findNotification);

// 캐시에서 해당 알림 제거
deleteNotificationCacheById(userId, notificationId);
Expand All @@ -132,6 +137,7 @@ public List<NotificationUpdateReadResponseDto> updateAllNotificationRead(Long us

for (Notification notification : notificationList) {
notification.updateRead();
notificationRepository.save(notification);
result.add(NotificationUpdateReadResponseDto.fromNotification(notification));
}
stringRedisTemplate.delete(CACHE_PREFIX + userId);
Expand All @@ -147,6 +153,7 @@ public NotificationAlarmResponseDto updateNotificationAlarm(Long userId, boolean

// 알람 수신 여부 업데이트
findUser.updateAlarmSetting(isAlarmEnabled);
userRepository.save(findUser);

return NotificationAlarmResponseDto.fromNotification(findUser);
}
Expand All @@ -162,7 +169,8 @@ public void handleVacancyNotification(User user, Long storeId) {
.findByUserAndStoreAndIsNotifiedFalse(user, store)
.orElseThrow(() -> new HandledException(ErrorCode.WAITLIST_NOT_FOUND));

waitlist.updateNotified();
waitlist.updateNotified();;
waitlistRepository.save(waitlist);
}

// 전체 알림 리스트를 페이징된 Page 객체로 변환
Expand Down