Skip to content

Empty HAL-Forms options inline attribute should be serialized #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reda-alaoui wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

Empty HAL-Forms options inline attribute should be serialized #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/springframework/hateoas/mediatype/hal/forms/HalFormsOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ private Inline(Collection<? extends Object> values, @Nullable String promptRef,
* @return
*/
@JsonProperty
@JsonInclude(Include.ALWAYS)
public Collection<? extends Object> getInline() {
return inline;
}
Expand Down
21 changes: 21 additions & 0 deletions ...org/springframework/hateoas/mediatype/hal/forms/HalFormsJacksonModuleIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,27 @@ void rendersFullInlineOptions() {
});
}

@Test // #2257
void rendersEmptyInlineOptions() {

var options = HalFormsOptions.inline()
.withPromptField("my-prompt-field")
.withValueField("my-value-field")
.withMinItems(2L)
.withMaxItems(3L);

getCuriedMapper()
.assertSerializes(options)
.into(result -> {

assertThat(result.read("$.inline", Collection.class)).isEmpty();
assertThat(result.read("$.promptField", String.class)).isEqualTo("my-prompt-field");
assertThat(result.read("$.valueField", String.class)).isEqualTo("my-value-field");
assertThat(result.read("$.minItems", Long.class)).isEqualTo(2L);
assertThat(result.read("$.maxItems", Long.class)).isEqualTo(3L);
});
}

@Test // #2257
void rendersFullRemoteOptions() {

Expand Down
Loading