This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Use Apartment::Tenant.drop instead of raw SQL#24
Open
zavan wants to merge 1 commit intospree-contrib:masterfrom
Open
Use Apartment::Tenant.drop instead of raw SQL#24zavan wants to merge 1 commit intospree-contrib:masterfrom
Apartment::Tenant.drop instead of raw SQL#24zavan wants to merge 1 commit intospree-contrib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
TenantInitializerto useApartment::Tenant.dropinstead of the rawDROP SCHEMA IF EXISTS #{db_name} CASCADESQL, which only works for PostgreSQL.This allows the task to be used with MySQL (which has no
CASCADEoption), SQLite3 (which "drops databases" by deleting the DB file), and other adapters supported by apartment, besides PostgreSQL.Fixes #13.
I also think that the task shouldn't drop existing tenants by default, but only if the user passes a "force" flag. But this is a separate issue.