Public Doc -> GA Release of New Secops rest apis #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamirYaariSpot
requested review from
TamirYaariSpot
and removed request for
TamirYaariSpot
TamirYaariSpot
suggested changes
Nov 21, 2024
| anyOf: | ||
| - type: string | ||
| - type: 'null' | ||
| title: Paginationkey |
Contributor
There was a problem hiding this comment.
no need for the title
Contributor
Author
There was a problem hiding this comment.
this is also generated by FastAPI library not in our control
| allOf: | ||
| - $ref: ./PaginatedResponse_ComplianceModel_.yaml | ||
| responseTime: | ||
| title: Responsetime |
Contributor
There was a problem hiding this comment.
no need for title - please fix for all fields (creates unneeded duplication since field name already appears there)
api/services/security/v1/schemas/SpotResponse_PaginatedResponse_ComplianceModel__.yaml
Outdated
Show resolved
Hide resolved
api/services/security/v1/schemas/SpotResponse_PaginatedResponse_ComplianceModel__.yaml
Show resolved
Hide resolved
api/services/security/v1/schemas/SpotResponse_PaginatedResponse_AssetSimFilterModel__.yaml
Outdated
Show resolved
Hide resolved
…ture/SPOTSEC-4343/public-docs-secops-rest-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Include a link to your Jira Ticket
https://spotinst.atlassian.net/browse/SPOTSEC-4343
Demo
Screen.Recording.2024-10-24.at.2.28.50.PM.mov
Checklist: