Conversation
Contributor
|
I support this |
spnda
force-pushed
the
cpp20
branch
6 times, most recently
from
bdc94da to
aef6c3e
Compare
spnda
force-pushed
the
cpp20
branch
2 times, most recently
from
0a3bf34 to
8899291
Compare
This currently only includes changes about functions and types that only existed as a compatibility layer or to add features that didn't exist in C++17. Fix float/double sentinel values for Optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to various reasons, including the fact that the codebase already used plenty of C++20 features and that C++20 is now mature enough to be used in widespread applications in my opinion, I want to update fastgltf to be a C++20 library.
As this cppreference page shows all relevant compilers (not just the big-three) support next to every single C++20 feature, and have for years now. These compiler versions are now popular and widespread making upgrading to any future version of fastgltf no problem.
There's still many more changes this PR needs, mainly about upgrading various other pieces of the codebase to use C++20 features, modernizing everything. I'm particularly interested in adopting C++ ranges and concepts as much as possible. I'm mainly opening this PR as a way to get feedback and maybe catch potential issues these major changes might have caused.