Support of multi accounts files #10#64
Open
gustawdaniel wants to merge 14 commits intospmason:masterfrom
Open
Conversation
spmason
reviewed
Oct 16, 2020
Owner
spmason
left a comment
There was a problem hiding this comment.
The changes look mostly fine, thanks for contributing. There's just some cleanup to do and I think the date-format-guessing needs to be removed
|
|
||
| function parseDate(dateStr, formats) { | ||
| if (formats === 'us') { | ||
| if (formats === 'us' || dateStr.includes("'")) { |
Owner
There was a problem hiding this comment.
It seems a bit risky to say that any dateStr that includes a ' is a US date format
Contributor
Author
There was a problem hiding this comment.
Is there any better proposition? This code do not breaks compatibility but is open also for other date format, that I am using.
Owner
There was a problem hiding this comment.
Per #26 you can pass in a dateFormat option to control how the dates are parsed. us is only supported for backward compatibility
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.1 to 2.22.1. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.20.1...v2.22.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…lint-plugin-import-2.22.1
# Conflicts: # lib/qif2json.js # test/accounts.tests.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request packages are updated:
Support for multi accounts files was added.
Support for single account files was not changed.
Structure of single account json:
Structure of multi account json: