Make cla check clearer #1673
Open
Make cla check clearer #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set default environment in Makefile to 'default'. - Remove unnecessary variable assignment in Makefile. - Ensure removal of _.yaml file is forced in Makefile. - Update CLA check workflow to improve PR comment messages and conditions for signing the Code of Conduct. - Adjusted conditions for triggering COC assistant based on PR comments.
Contributor
|
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
| ENVIRONMENT ?= ${1} | ||
| ${ENVIRONMENT}: | ||
| ENVIRONMENT = default | ||
| ENVIRONMENT ?= default |
Collaborator
There was a problem hiding this comment.
Is there a reason this was changed? I think we want this to be configurable, and it seems unrelated to the CLA check.
| allowlist: dependabot[bot] | ||
| remote-organization-name: splunk | ||
| remote-repository-name: cla-agreement | ||
| custom-notsigned-prcomment: "<br/>Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contribution License Agreement](${input.getPathToDocument()}) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.<br/>" |
Collaborator
There was a problem hiding this comment.
Can you change the last sentence to say You can sign the CLA by just posting a Pull Request Comment with the exact sentence copied from below.? I think that is more clear.
| signed-commit-message: "$contributorName has signed the COC in #$pullRequestNo" | ||
| custom-notsigned-prcomment: "All contributors have NOT signed the COC Document" | ||
| custom-allsigned-prcomment: "****CLA Assistant Lite bot**** All contributors have signed the COC ✍️ ✅" | ||
| custom-notsigned-prcomment: "<br/>🎉 **CLA signed — one more step to go!**<br/><br/>Please also accept our [Code of Conduct](${input.getPathToDocument()}) by posting a comment in the format below. This helps us maintain a welcoming community.<br/>" |
Collaborator
There was a problem hiding this comment.
Can you change the middle sentence to say by posting a comment with the exact sentence copied from below.? I think that is more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make CLA & COC signing more clear
Key Changes
Clear communication about CLA and COC check
Avoid race condition
Minor fixes in makefile
Testing and Verification
Makefile - running it locally
CLA & COC - TBH - I checked it with docuemtnation, it's hard to test it properly locally
Related Issues
PR Checklist