Added Dashboard Group and Sample Detectors for Inferred Services#80
Conversation
|
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I have read the Code of Conduct and I hereby accept the Terms |
greatestusername-splunk
left a comment
greatestusername-splunk
left a comment
There was a problem hiding this comment.
A few ease of use asks but otherwise approved.
This looks great and thank you so much for contributing this!
| @@ -0,0 +1,90 @@ | |||
| curl --location 'https://api.us1.signalfx.com/v2/detector' \ | |||
| --header 'Content-Type: application/json' \ | |||
| --header 'X-SF-TOKEN: REPLACEME' \ | |||
There was a problem hiding this comment.
Might I suggest pulling from an environment variable in these scripts and noting the env var to use in the README so folks don't have to put their key in a file?
Thoughts?
| @@ -0,0 +1,57 @@ | |||
| curl --location 'https://api.us1.signalfx.com/v2/detector' \ | |||
| --header 'Content-Type: application/json' \ | |||
| --header 'X-SF-TOKEN: REPLACEME' \ | |||
There was a problem hiding this comment.
same thought here RE: env var
| ## Inferred Services - Sample Detectors | ||
|  | ||
|
|
||
| Use curl command to post the detector (replace `Token` and `Realm` as required). |
There was a problem hiding this comment.
typo? Uses
Maybe "This script uses the curl command..."?
| @@ -0,0 +1,90 @@ | |||
| curl --location 'https://api.us1.signalfx.com/v2/detector' \ | |||
There was a problem hiding this comment.
please chmod the *.sh files to something like 766 so anyone can read/write but only owner can execute. Currently script isn't executable without chmoding it.
|
|
||
| Use curl command to post the detector (replace `Token` and `Realm` as required). | ||
|
|
||
| These can be used as a starting point to customise signals, thresholds, messaging etc. |
There was a problem hiding this comment.
Would you mind noting something along the lines of
"The created detector will not be filtered to any specific inferred service and will not have any notification paths set unless you make those changes in the detector or script."
Just so folks know they are going to need to configure a few things in particular?
2 participants
Assets to help using new inferred.services metrics: Dashboard group & Sample detectors.