Conversation
pyth0n1c
previously approved these changes
Jun 13, 2025
Contributor
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
These changes look good. In the future, we should come up with a more scalable way to do this type of thing (allowing reference to dependencies in other apps).
Ideally, we should not have to update the contentctl codebase for this, we should be able to update a "content file"
pyth0n1c
approved these changes
Jun 13, 2025
Contributor
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
just a version bump this time, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splunk/security_content#3544 depends on the use of the
mitre_attack_lookuplookup provided by ES.splunk/security_content#3558 depends on the use of the
globedistance()macro and theasn_lookup_by_cidrlookup, both provided by ES.This stubs them both into the ignore lists- detections will be updated w/ appropriate flags (We should probably have a different state that allows for unit tests to run when ES is present instead of having to default to manual_testing?)