detection_Type and _entities conf file updates#404
Merged
Conversation
per detection. Significant cleanup of the savedstories_detections.j2 template to make other changes easier. The changes in this template still generate an identical savedsearches.conf file before the changes.
fields to savedsearches.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These set of changes adds, where appropriate, the _entities and detection_type fields to savedsearches.conf
It also SIGNIFICANTLY cleans up savedsearches_detections.j2. There was a lot of complexity that was no longer required in this file (as a holdover from when Detection objects were dicts, not classes), making it challgening to understand.
It should be far easier now.