Skip to content

Validation output improvements#402

Merged
pyth0n1c merged 8 commits intomainfrom
validation-output_fixes
Apr 29, 2025
Merged

Validation output improvements#402
pyth0n1c merged 8 commits intomainfrom
validation-output_fixes

Conversation

@ljstella
Copy link
Copy Markdown
Contributor

Adjusts offsets to pipes align to actually close the "boxes"

@ljstella
Copy link
Copy Markdown
Contributor Author

Before:

Screenshot 2025-04-29 at 3 59 03 PM

After:

Screenshot 2025-04-29 at 4 00 44 PM

pyth0n1c
pyth0n1c previously approved these changes Apr 29, 2025
Copy link
Copy Markdown
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ljstella
Copy link
Copy Markdown
Contributor Author

ljstella commented Apr 29, 2025

Dark mode (Catppuccin Mocha), for reference:

Screenshot 2025-04-29 at 4 34 01 PM

Looking better aligned locally (unclear what's going on in CI), actually works on Windows again, and I've reset the template repo's detection back to what it was so CI should be green again.

@ljstella
Copy link
Copy Markdown
Contributor Author

Windows CI Runner ouput:
Screenshot 2025-04-29 at 4 29 45 PM

@ljstella ljstella requested a review from pyth0n1c April 29, 2025 21:59
Copy link
Copy Markdown
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better and passing now with windows when there are validation exceptions as well. nice work!

@pyth0n1c pyth0n1c merged commit dd20cf7 into main Apr 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants