Fix pathing issue on Windows and Cleanup Typing#393
Merged
Conversation
actual path objects instead of strings for nicer typing and more pythonic code
Contributor
|
Living up to the username @pyth0n1c 😉 This is much better than my proposed fix! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR came in from @0xC0FFEEEE here with a fix for release_notes on Windows:
#391 (review)
Based on my comment, we may want to convert the names of these directories, which are currently a string, to paths so that we can be a bit more pythonic.
@0xC0FFEEEE , could you give your thoughts on whether this ALSO fixes your issue while improving the code in a different way as well?
Thanks!