Merged
Conversation
… an error parsing a yml file. Right now we do not, which makes debugging and fixing the error needlessly complicated
pyth0n1c
commented
Mar 28, 2025
Contributor
Author
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
I have tested this locally with some badly formatted YMLs.
This looks good to me, as it is a small change I am approving and merging myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the name of the YML file which causes an exception when there is an error parsing a yml file. Right now we do not, which makes debugging and fixing the error needlessly complicated
For example, instead of crashing, we will give the most verbose error we can. For example, this is the result of trying to parse an invalid YML now
Unfortunately, we can't give a more detailed error than this, or recommendation of what to fix, but this is typically enough that when the file is opened, especially in an IDE with YML support, it is clear what the issue is.