[composites] Consistently terminate composites#481
Merged
Conversation
sea-bass
force-pushed
the
terminate-composites
branch
from
fe1e1a1 to
9df1d14
Compare
sea-bass
changed the title
This was referenced Nov 13, 2025
sea-bass
commented
Nov 13, 2025
Comment on lines
-543
to
+552
| assert self.current_child is not None # should never be true, help mypy out | ||
| elif self.memory and self.current_child is not None: | ||
| index = self.children.index(self.current_child) | ||
| elif not self.memory and common.Status.RUNNING: | ||
| elif not self.memory: |
sea-bass
force-pushed
the
terminate-composites
branch
4 times, most recently
from
3cef265 to
a042d54
Compare
sea-bass
force-pushed
the
terminate-composites
branch
from
a042d54 to
dcf06d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that Sequences and Selectors always stop themselves on a terminal state... which was not happening before.
For reference, Parallels already did terminate themselves on terminal states.
I also went through and made some small fixes to reported logic issues.
Partially closes #458
Closes #477
Closes #480