This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Updating deprecated @expectedException annotations#12
Open
aywan wants to merge 2 commits intospiral-modules:masterfrom
Open
Updating deprecated @expectedException annotations#12aywan wants to merge 2 commits intospiral-modules:masterfrom
aywan wants to merge 2 commits intospiral-modules:masterfrom
Conversation
…exception message.
Member
|
Thank you! Let's see the tests to finish |
Member
|
Coding standards are violated. Try running |
vvval
suggested changes
Oct 19, 2020
Contributor
vvval
left a comment
vvval
left a comment
There was a problem hiding this comment.
Thank you work your work. Unfortunately, some of the changes are implemented and have to be removed (see suggestions)
Comment on lines
+244
to
+246
| $this->expectException(\Spiral\Migrations\Exception\Operation\ColumnException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to rename column '.+'\.'.+', column does not exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\ColumnException::class); | |
| $this->expectExceptionMessageMatches("/Unable to rename column '.+'\.'.+', column does not exists/"); |
Comment on lines
+451
to
+453
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to add foreign key '.+'\.(.+), foreign key already exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | |
| $this->expectExceptionMessageMatches("/Unable to add foreign key '.+'\.(.+), foreign key already exists/"); |
Comment on lines
+427
to
+429
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to drop foreign key '.+'\.'.+', foreign key does not exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | |
| $this->expectExceptionMessageMatches("/Unable to drop foreign key '.+'\.'.+', foreign key does not exists/"); |
Comment on lines
+394
to
+396
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to alter foreign key '.+'\.'.+', foreign column '.+'\.'.+' does not exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | |
| $this->expectExceptionMessageMatches("/Unable to alter foreign key '.+'\.'.+', foreign column '.+'\.'.+' does not exists/"); |
Comment on lines
+365
to
+367
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to alter foreign key '.+'\.'.+', foreign table '.+' does not exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\ForeignKeyException::class); | |
| $this->expectExceptionMessageMatches("/Unable to alter foreign key '.+'\.'.+', foreign table '.+' does not exists/"); |
Comment on lines
+91
to
+93
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to update table '.+'\.'.+', no table exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | |
| $this->expectExceptionMessageMatches("/Unable to update table '.+'\.'.+', no table exists/"); |
Comment on lines
+69
to
+71
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to create table '.+'\.'.+', table already exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | |
| $this->expectExceptionMessageMatches("/Unable to create table '.+'\.'.+', table already exists/"); |
Comment on lines
+52
to
+54
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to create table '.+'\.'.+', no columns were added/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | |
| $this->expectExceptionMessageMatches("/Unable to create table '.+'\.'.+', no columns were added/"); |
Comment on lines
+35
to
+37
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to drop table '.+'\.'.+', table does not exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | |
| $this->expectExceptionMessageMatches("/Unable to drop table '.+'\.'.+', table does not exists/"); |
Comment on lines
+308
to
+310
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | ||
| $this->expectExceptionMessageMatches("/Unable to set primary keys for table '.+'\.'.+', table already exists/"); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\Spiral\Migrations\Exception\Operation\TableException::class); | |
| $this->expectExceptionMessageMatches("/Unable to set primary keys for table '.+'\.'.+', table already exists/"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes deprecated annotations.
And also add asserting exception message. Not sure that this right. Can remove it.