Spec fixes for Ruby 3.4 (and Ruby 3.5) #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> warning: ostruct was loaded from the standard library, but will no > longer be part of the default gems starting from Ruby 3.5.0.
It is no longer maintained as it moved to the RubyGems/Bundler repo. It looks very different today. - segiddins/automatiek#10 - ruby/rubygems#3750 - https://github.com/rubygems/rubygems/blob/221f982b255827571f44130ad7b91aca1797f05f/tool/automatiek/vendor.rb
Running the tests before this change included this warning in the output
(and causing them to fail):
/usr/local/lib/ruby/3.4.0/readline.rb:4: warning: reline was loaded from
the standard library, but w...from Ruby 3.5.0.\nYou can add reline to
your Gemfile or gemspec to silence this warning.
This is because Thor requires "readline", and in Ruby 3.4, that will try
to load "reline":
$ cat /Users/dentarg/.arm64_rubies/3.4.1/lib/ruby/3.4.0/readline.rb
begin
require "readline.#{RbConfig::CONFIG["DLEXT"]}"
rescue LoadError
require 'reline' unless defined? Reline
Object.send(:remove_const, :Readline) if Object.const_defined?(:Readline)
Readline = Reline
end
This change is the same as rails/thor@7061b06
That change is part of Thor v1.0.0 and up, but vendoring that version
will be a future task (breaking changes in the CLI?).
Other projects having to address the same thing: - haml/haml#1173 - rails/rails#53202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.