handle dual-position player in team.roster() #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis Hunter is a dual-position player (WR and DB) in Yahoo Fantasy, and the JSON response includes a linked_player field with his defensive player data. The old roster parsing code used a deep recursive ObjectPath query ($..) that picked up fields from inside the linked_player object, causing the sequential next() calls to misalign and crash. I completely rewrote the roster() method to avoid deep recursion. Instead, I navigate directly to the roster structure.
This is an auto-generated PR with fixes by autopep8. Co-authored-by: spilchen <spilchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis Hunter is a dual-position player (WR and DB) in Yahoo Fantasy, and the JSON response includes a linked_player field with his defensive player data. The old roster parsing code used a deep recursive ObjectPath query ($..) that picked up fields from inside the linked_player object, causing the sequential next() calls to misalign and crash.
I completely rewrote the roster() method to avoid deep recursion. Instead, I navigate directly to the roster structure.
Closes #65