Update for league_ids function in Game Class #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the league_ids function to leverage the leauges collection instead of the teams collection.
Collaborator
Author
|
@spilchen Not sure how you want to handle something like this, would be a breaking change for anyone using league_ids function as it will have a new signature. |
DMcP89
added a commit
to DMcP89/harambot
that referenced
this pull request
Mar 26, 2025
Collaborator
Author
|
@spilchen would like to get your approval before merging as this would be a breaking change |
spilchen
reviewed
Apr 2, 2025
Collaborator
Author
|
@spilchen updated, let me know if there are any other changes |
spilchen
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the league_ids function to leverage the leagues collection instead of the teams collection.