Add support for waivers with faab #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@spilchen Can I get a review pls? Thanks! |
spilchen
reviewed
Jan 19, 2025
Owner
spilchen
left a comment
spilchen
left a comment
There was a problem hiding this comment.
Thanks for contributing! Can you bump the version in setup.py to 2.10.0?
|
|
||
|
|
||
| def test__construct_transaction_xml(mock_team): | ||
| with open(f'{DIR_PATH}/add_drop_with_faab.xml', 'r') as file: |
Owner
There was a problem hiding this comment.
add_drop_with_faab.xml file is missing from the PR. Can you commit it? Same with add_drop_no_faab.xml below.
Contributor
Author
There was a problem hiding this comment.
Oops, just added them. Thanks!
Contributor
Author
@spilchen Changes addressed. Thanks for this project! |
spilchen
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Team methods for bidding faab on waiver claims.
Testing
Confirmed in my home league that with these new methods I could successfully make waiver claims, whereas using the existing
add_playerandadd_and_drop_playersmethods would encounter: